Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
0hmX
force-pushed
the
feat/break-into-subsolvers
branch
from
4ea3f52 to
d385a60
Compare
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
forgot to post these comments earlier today
|
The size increase is from svg, the actual amount of code is the same |
| } | ||
| } | ||
|
|
||
| return baseViz |
There was a problem hiding this comment.
This should use combineVisualizations, same as the AutoroutingPipelineSolver (all pipelines do is combine visualizations, they shouldnt do anything unique- each stage gets its own “step”, check AutoroutingPipelineSolver)
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
Why would you rename the solver like that
Was this something else you mean? |
2 participants
to be merged after #30
Some of the diff you see are the changes done in #30, but since it's not merged yet, we are seeing them in file changes